Delivery transaction must use all the districts (#360) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivanov89
force-pushed
the
fix-districts-in-delivery
branch
2 times, most recently
from
14d4428
to
f285fbc
Compare
eivanov89
force-pushed
the
fix-districts-in-delivery
branch
from
f285fbc
to
326c3c9
Compare
|
@apavlo could you please have a look and approve the workflow? |
|
@apavlo ping |
apavlo
reviewed
Oct 27, 2023
| @@ -104,7 +104,7 @@ public void run(Connection conn, Random gen, int w_id, int numWarehouses, int te | |||
|
|
|||
| int[] orderIDs = new int[10]; | |||
|
|
|||
| for (d_id = 1; d_id <= terminalDistrictUpperID; d_id++) { | |||
| for (d_id = 1; d_id <= w.getDistPerWhse(); d_id++) { | |||
There was a problem hiding this comment.
Instead of getting the districts per warehouse from TPCCWorker, why not just use TPCCConfig.configDistPerWhse since it never changes?
There was a problem hiding this comment.
You're right, thank you! I've updated the pull request. And I'm sorry, that it took so long time.
eivanov89
force-pushed
the
fix-districts-in-delivery
branch
3 times, most recently
from
87d797c
to
a4cbd2a
Compare
eivanov89
force-pushed
the
fix-districts-in-delivery
branch
from
a4cbd2a
to
3af16c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.