Enforce and apply Google Java Style formatting #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
changed the title
bpkroth
added a commit
to bpkroth/benchbase
that referenced
this pull request
Dec 14, 2023
Follow-on work to cmu-db#416, this file uses a [`.git-blame-ignore-revs` file](https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view) to ignore revs that cause major reformatting changes in git blame view.
bpkroth
added a commit
that referenced
this pull request
Dec 14, 2023
Follow-on work to #416, this file uses a [`.git-blame-ignore-revs` file](https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view) to ignore revs that cause major reformatting changes in git blame view.
This was referenced Dec 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This builds off of #413, so that should be merged first.
Uses fmt-maven-plugin to automatically (locally) apply Google Java Style formatting via the google-java-format plugin during
mvn compiletime.During CI time, it checks for incorrect formatting on files prior to compile to automatically reject failing commits so that reviewers have fewer things to nit over and code style is more standardized.
This is not yet enforced by a git pre-commit however, so developers will have to add the changes that the
compilestage applied after the fact.Additionally, it adds settings for VSCode to apply these formattings during editing.
Followup PR can also exclude this squashed PR from the
git blameanalysis using a.git-blame-ignore-revsfileCloses #406