Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace evaluate_chu with evalcast::evaluate_covid_predictions #165

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

nmdefries
Copy link
Collaborator

National data is now available in covidcast so replace custom evaluate_chu with evalcast's evaluate_covid_predictions, already used for scoring state forecasts.

@brookslogan
Copy link
Collaborator

Have you already verified that the new national truth data match the corresponding covidHubUtils ones? (I think national hospitalizations should match except for some things that don't matter: covidcast including time_values on or before 2020-07-27 (which aren't visualized anyway), and differences from timing of updates (which don't matter as eventually both sources will receive the same updates).)

@dajmcdon
Copy link
Collaborator

Right. I was going to say the same thing as @brookslogan . Before we change, we've got to make sure that the data matches.

@nmdefries nmdefries marked this pull request as draft September 20, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants