Revert "testmap: Retire cockpit rhel-9.3 branch" #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some more RHEL 9.3 z-stream updates to do. This reverts commit 1dce72d.
jelly
previously approved these changes
Dec 12, 2023
|
Should we not run the tests here and see if they pass? |
|
@jelly See description -- tests need some love, cockpit-project/cockpit#19734 -- I'm working on it. Fortunately I can trigger the test from my local bots checkout, so if you prefer we can block this PR on the cockpit one. |
|
I needed to restore a naughty pattern for this failure. |
jelly
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some more RHEL 9.3 z-stream updates to do.
This reverts commit 1dce72d.
Not running tests here. The branch needs some test adjustments, this needs to land together with cockpit-project/cockpit#19734