networking: Increase checkpoint settle time #13534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to commit f1d06ab, but bump it harder. Right after starting the test and cockpit, the VMs are fairly loaded (particularly rhel-8-2), so that eth0 does not get shut down quickly enough and the checkpoint_destroy() succeeds. As a result, Cockpit just disconnects, the curtain never comes up, and there is never a restore. Fixes cockpit-project#13532
|
@mvollmer: If that is somehow not good enough, an alternative "fix" would be to add some sleeping to the beginning of check-networking-checkpoint to let the VM settle down a bit. |
|
This also happens on fedora-31. Not surprising, I just saw it less often. |
mvollmer
approved these changes
Feb 12, 2020
|
I think a longer settle time is okay. Now people get to see a broken UI for four seconds when they accidentally disconnect themselves, but that still feels short enough to not be confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to commit f1d06ab, but bump it harder. Right after
starting the test and cockpit, the VMs are fairly loaded (particularly
rhel-8-2), so that eth0 does not get shut down quickly enough and the
checkpoint_destroy() succeeds. As a result, Cockpit just disconnects,
the curtain never comes up, and there is never a restore.
Fixes #13532