test: Don't explicitly go to x0.cockpit.lan in TestIPA #21064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x0.cockpit.lan is the name of the local machine, but specifying it
with login_and_go will navigate to it as a remote host, using a URL
like
https://127.0.0.2:9091/@x0.cockpit.lan
This is not needed since the test only wants the session on localhost,
and doesn't care what happens inside the session. It would be harmless
except that Cockpit might spontaneously open the "Add host" dialog for
"x0.cockpit.lan", which will make the session menu inaccessible for
the subsequent logout. (Only on Firefox, Chrome manages to open it
anyway.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x0.cockpit.lan is the name of the local machine, but specifying it with login_and_go will navigate to it as a remote host, using a URL like
This is not needed since the test only wants the session on localhost, and doesn't care what happens inside the session. It would be harmless except that Cockpit might spontaneously open the "Add host" dialog for "x0.cockpit.lan", which will make the session menu inaccessible for the subsequent logout. (Only on Firefox, Chrome manages to open it anyway.)