Simplifying color setup #1320
Closed
Simplifying color setup #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the _fontColor object's CGColor property to setup the context rather than making a new CGColor object and then deleting it. NSMutableAttributedStringFixPlatformSpecificAttributes will also use the _fontColor CGColor so this change doesn't create an object that wasn't going to be created anyway, and we get some reuse.
richardgroves
added a commit
to NoodlFroot/cocos2d-objc
that referenced
this pull request
May 7, 2015
richardgroves
added a commit
to NoodlFroot/cocos2d-objc
that referenced
this pull request
Nov 17, 2015
|
I can't find a way to merge it to other branch (develop-v3.5). Can somebody advice how to merge PR into other target branch. Or can @richardgroves change target branch himself? |
|
Will take a look at re-targeting the PR to the 3.5 branch |
|
Ok - ~1400 comments asking for GitHub to implement changing the branch - isaacs/github#18 - but it still can't be done. Will repurpose the ~5 line change onto the new branch. |
|
Well, I can merge it manually too. it's not about my lazyness, it's about keeping things git (is it a phrase at all?). |
|
It's OK - doing a new PR and will reference this one for completeness. |
richardgroves
added a commit
to richardgroves/cocos2d-iphone
that referenced
this pull request
Mar 7, 2016
Repeat of PR in cocos2d#1320 that got lost due branch changes and GitHub limitations.
|
Redone in #1365 |
s1ddok
pushed a commit
that referenced
this pull request
Nov 27, 2016
Repeat of PR in #1320 that got lost due branch changes and GitHub limitations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the _fontColor object's CGColor property to setup the context rather than making a new CGColor object and then deleting it. NSMutableAttributedStringFixPlatformSpecificAttributes will also use the _fontColor CGColor so this change doesn't create an object that wasn't going to be created anyway, and we get some reuse.