Server status - Show to all users

[ihsaan-ullah]

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now all users can see server_status page.
Everything stays the same for super admin but for normal users they can do the following:

• see their own submissions
• see the submissions which are using a queue whose owner is this user.

Note: a user can see past submissions too if you change a queue in a competition from default to this user's queue. And user can lose all submissions showing before but not anymore because queue is changed to another queue. This happens because queue is part of a competition and not a submission.

Screenshots:

status page link in the menu:

user ihsan01 can see his own submissions running on default queue (*) and he can also see some other submissions from other user because they are running on queue: aaa whose owner is ihsan01

Button in queue page to go to

server status page

Issues this PR resolves

• We need more information in job status page #744 -> users should be able to see status page with their own submissions only
• We need more information in job status page #744 -> Users should be able to see only the queue they are administrating. This is indeed useful when debugging and monitoring a competition
• We need more information in job status page #744 -> When this is done, we should add a button in the Queue Management page that redirects to the job status page.

Checklist

• Code review by me
• Hand tested by me
• I'm proud of my work
• Code review by reviewer
• Hand tested by reviewer
• CircleCi tests are passing
• Ready to merge

[Didayolo]

@ihsaan-ullah

It is not due to this PR, because I can reproduce the bug in develop, but I have identified a problem.

Steps to reproduce:

• Create a queue "Test 1", and link it to a competition
• Make a submission
• Change the queue of the competition to another one, "Test 2"
• Now, in the server status, the two submissions are marked as submitted to the queue "Test 2" (and the owner of the queue "Test 2" can see both)

We just have to change the queue, without re-submitting, and the queue is changed for all submissions:

---

The problem may come from this PR #1091

The way the queue is taken basically just reads the queue of the competition, and not the queue in which the submission was done?

[ihsaan-ullah]

@ihsaan-ullah

It is not due to this PR, because I can reproduce the bug in develop, but I have identified a problem.

Steps to reproduce:

• Create a queue "Test 1", and link it to a competition
• Make a submission
• Change the queue of the competition to another one, "Test 2"
• Now, in the server status, the two submissions are marked as submitted to the queue "Test 2" (and the owner of the queue "Test 2" can see both)

I agree with this. This is what I mentioned in the Note in the PR:

Note: a user can see past submissions too if you change a queue in a competition from default to this user's queue. And user can lose all submissions showing before but not anymore because queue is changed to another queue. This happens because queue is part of a competition and not a submission.

We just have to change the queue, without re-submitting, and the queue is changed for all submissions:

We are not changing the queue of submission. The problem is that queue is not linked to a submission but to a competition. We can get the queue from competition only.

The problem may come from this PR #1091

No this PR is just displaying thename of the queue of the competition which has this submission.

The way the queue is taken basically just reads the queue of the competition, and not the queue in which the submission was done?

Yes you are right. I think there is no way to track the queue of submission. I maybe wrong but I did not find it anywhere

[Didayolo]

@ihsaan-ullah That's interesting. I am not really concerned about the potential leakage of information when you switch the queue; if the competition is using your queue, then you are most probably one of the competition organizers. Also, this interface does leak very sensitive information such as IP address of the workers.

The main problem is more that the table is a bit confusing. When trying to debug submissions, if you are not aware of this behavior, it can be misleading.

[ihsaan-ullah]

@ihsaan-ullah That's interesting. I am not really concerned about the potential leakage of information when you switch the queue; if the competition is using your queue, then you are most probably one of the competition organizers. Also, this interface does leak very sensitive information such as IP address of the workers.

The main problem is more that the table is a bit confusing. When trying to debug submissions, if you are not aware of this behavior, it can be misleading.

We should discuss this in the meeting to plan something for it