Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participant Registration Status #1133

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Participant Registration Status #1133

merged 2 commits into from
Sep 3, 2023

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Sep 2, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

UI updated to show different messages for pending and denied statuses

Pending:
Screenshot 2023-09-02 at 9 32 45 PM

Denied:
Screenshot 2023-09-02 at 9 32 14 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Sep 2, 2023 that may be closed by this pull request
@Didayolo Didayolo merged commit a774664 into develop Sep 3, 2023
1 check passed
@Didayolo Didayolo deleted the registration_message branch September 3, 2023 16:07
@Didayolo
Copy link
Collaborator

Didayolo commented Sep 3, 2023

I am testing this in https://codabench-test.lri.fr/ and when I try to register to a competition I get this error:

Capture d’écran 2023-09-03 à 18 14 41

Logs:

codabench-django-1       | Not Found: /api/competitions/147/register/
codabench-django-1       | Not Found: /api/competitions/147/register/

@Didayolo
Copy link
Collaborator

Didayolo commented Sep 3, 2023

It is not linked to this PR as I'm able to reproduce on the main instance.

OK, I think registration is incompatible with private competitions. I created a separate issue (#1135).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong message for revoked participant
2 participants