Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to make programs input data available #1136

Merged
merged 11 commits into from
Sep 6, 2023

Conversation

bbearce
Copy link
Collaborator

@bbearce bbearce commented Sep 3, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Added:

  • Make programs available
  • Make input data available

Issues this PR resolves

A checklist for hand testing

  • add all combinations of True\False for options in v1 and v2 competition.yaml files, import those comps and make sure in competition editor you see the options selected\unselected as you specified:
...
make_programs_available: True
make_input_data_available: True
...

Any relevant files for testing

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Collaborator

Didayolo commented Sep 4, 2023

  • The CircleCI tests are not passing. The main error seems to be this:
rest_framework.exceptions.ValidationError: {'make_programs_available': [ErrorDetail(string='This field may not be null.', code='null')], 'make_input_data_available': [ErrorDetail(string='This field may not be null.', code='null')]}
  • Also, I am wondering if make_programs_available and make_input_data_available are the best names for these variables. Maybe is_program_available and is_data_available instead?

  • Edit the documentation (https://github.com/codalab/codabench/wiki/Yaml-Structure)

  • Add a question mark (?) next to "Files available" to explain the role of the feature:

Capture d’écran 2023-09-05 à 17 08 54

@Didayolo Didayolo changed the title 764 make programs inputdata avail Options to make programs input data available Sep 4, 2023
@bbearce
Copy link
Collaborator Author

bbearce commented Sep 6, 2023

  • Names:
    Need consensus if we like the names of the options (make_programs_available/make_input_data_available) or if something else would be best.

  • Documentation:
    image
    image

  • Checkmarks:
    image

  • Question Mark:
    image

Qutstanding thoughts:
Should we hide the "Available" column altogether for non-organizers? It will always show a green check for whatever is available.

@Didayolo
Copy link
Collaborator

Didayolo commented Sep 6, 2023

Awesome work!

Should we hide the "Available" column altogether for non-organizers? It will always show a green check for whatever is available.

It is not crucial, but yes I guess it would be cleaner

@Didayolo Didayolo force-pushed the 764--make-programs-inputdata--avail branch from d336a01 to 7cb369e Compare September 6, 2023 13:03
@Didayolo
Copy link
Collaborator

Didayolo commented Sep 6, 2023

I rebased develop to have the recent changes (especially the migrations from #1126).

@Didayolo Didayolo merged commit c498383 into develop Sep 6, 2023
1 check passed
@Didayolo Didayolo deleted the 764--make-programs-inputdata--avail branch September 6, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants