Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Profile - Do not allow updation of email #1218

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Edit Profile - Do not allow updation of email #1218

merged 1 commit into from
Nov 10, 2023

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Nov 10, 2023 •
edited by Didayolo
Loading

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

The following are changed to not allow users to update email in edit profile:

  • disabled email input field
  • removed email from form values before sending to server (in case someone enables the input using inspect feature of browser)
Screenshot 2023-11-10 at 4 44 32 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Nov 10, 2023 that may be closed by this pull request
Email edit without any confirmation #1215
Closed
@Didayolo Didayolo merged commit 578bb3a into develop Nov 10, 2023
1 check passed
@Didayolo Didayolo deleted the email_update branch November 10, 2023 16:17
@Didayolo Didayolo mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email edit without any confirmation
2 participants
@ihsaan-ullah @Didayolo