Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main banner logos (CNRS, LISN, Paris-Saclay) #1219

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Main banner logos (CNRS, LISN, Paris-Saclay) #1219

merged 3 commits into from
Nov 10, 2023

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Nov 10, 2023

@ mention of reviewers

@acletournel @Didayolo

A brief description of the purpose of the changes contained in this PR.

Main banner now shows clickable logos for

  • LISN
  • Paris-Saclay
  • CNRS
Screenshot 2023-11-10 at 7 45 48 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah changed the title Logos Main banner logos (CNRS, LISN, Paris-Saclay) Nov 10, 2023
@ihsaan-ullah
Copy link
Collaborator Author

Latest upate with white logos

Screenshot 2023-11-10 at 8 20 02 PM

@acletournel
Copy link
Collaborator

acletournel commented Nov 10, 2023

Thanks a lot for the PR. It is nice on chromium, but logos appeared centered, below each other and not resized on firefox (very big). The rendering on dev tool for smartphone shows the same problem.
with 30% zoom in firefox:
image

@Didayolo
Copy link
Collaborator

Didayolo commented Nov 10, 2023

@acletournel @ihsaan-ullah I use Firefox and on my side the display is good:

Capture d’écran 2023-11-10 à 17 13 08

Did you run the following command?

docker-compose exec django ./manage.py collectstatic --noinput

@ihsaan-ullah
Copy link
Collaborator Author

For me too everythings is ok

Firefox
firefox

Chrome
chrome

Safari
safari

hopefully collectstatic will fix the sizing issue

@Didayolo Didayolo merged commit e38b1e3 into develop Nov 10, 2023
1 check passed
@Didayolo Didayolo deleted the logos branch November 10, 2023 16:18
@Didayolo
Copy link
Collaborator

Didayolo commented Nov 10, 2023

I merged it. @acletournel, please tell us if it's working fine here for you:

A hard refresh (maj + refresh) may be required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants