Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard number of entries #1330

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 14, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

In leaderboard, exclude failed and canceled submissions from num_entries

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Feb 14, 2024 that may be closed by this pull request
@Didayolo Didayolo merged commit 52b84d4 into develop Feb 15, 2024
1 check passed
@Didayolo Didayolo deleted the leaderboard_num_submissions branch February 15, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of entries includes failed submissions
2 participants