Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html tags in email text #1340

Merged
merged 1 commit into from
Feb 22, 2024
Merged

html tags in email text #1340

merged 1 commit into from
Feb 22, 2024

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 17, 2024

@Didayolo

we need to test this on test server. I think this change should fix the issue

How to test:

Send an email to a participant with text:

**bold** [link](https://codabench.org)

Participant should receive:

bold link

Participant should not receive:

<strong>bold</strong> <a href="https://codabench.org">link</a>

Why I think this is fixed?

Before the fix, I see the following in the django logs:

<p>&lt;strong&gt;bold&lt;/strong&gt; &lt;a href="https://codabench.org"&gt;link&lt;/a&gt;</p>

after the fix I see this:

<p><strong>bold</strong> <a href="https://codabench.org">link</a></p>

If this fixes the problem, then I will cleanup and add some comments

@Didayolo
Copy link
Collaborator

The mail service from the test server seems to have a problem.

  • I sent an email from codabench.org it worked
  • I sent an email from codabench-test.lri.fr it did not work

@Didayolo
Copy link
Collaborator

@Didayolo
Copy link
Collaborator

@ihsaan-ullah

With noreply@codabench-test.lri.fr it does not work:

Capture d’écran 2024-02-22 à 17 00 11

@ihsaan-ullah
Copy link
Collaborator Author

I think we need to create this email noreply@... associated with the domain codabench-test...

But we can still test this fix right?

@Didayolo
Copy link
Collaborator

Yes, we can still test the fix. I'll do it. The mailing problem is simply a configuration problem of the test server.

@Didayolo Didayolo self-assigned this Feb 22, 2024
@Didayolo
Copy link
Collaborator

@bbearce I forgot that we assigned you to this review. I am already doing it right now 👍

@Didayolo Didayolo merged commit b12fb43 into develop Feb 22, 2024
1 check passed
@Didayolo Didayolo deleted the user_email branch February 22, 2024 19:12
@Didayolo
Copy link
Collaborator

Tested on production and it works!

@ihsaan-ullah
Copy link
Collaborator Author

Tested on production and it works!

nice. I am closing the related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants