-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caddy #1424
Conversation
This looks good. We tested it together on Obada's system and everything was working perfectly. Certificates are stored in the data directory and the restart of the stack does not affect the certificates. We also deleted the certificate to verify that new certificate is generated. Another test may be needed on Codabench test |
Additionally, CircleCI tests are not passing E selenium.common.exceptions.TimeoutException: Message: TimedPromise timed out after 300000 ms
/usr/local/lib/python3.8/site-packages/selenium/webdriver/remote/errorhandler.py:242: TimeoutException =========================== short test summary info ============================
FAILED src/tests/functional/test_competitions.py::TestCompetitions::test_manual_competition_creation
FAILED src/tests/functional/test_login.py::TestLogin::test_login - selenium.c...
FAILED src/tests/functional/test_submissions.py::TestSubmissions::test_v15_iris_code_submission_end_to_end
FAILED src/tests/functional/test_submissions.py::TestSubmissions::test_v15_iris_result_submission_end_to_end
============= 4 failed, 5 passed, 9 warnings in 1420.46s (0:23:40) ============= |
I updated the branch (it was 31 commits behind develop), the CircleCI tests now fail at a different place src/tests/functional/test_competitions.py .... [ 44%]
src/tests/functional/test_login.py . [ 55%]
src/tests/functional/test_submissions.py .FFFE [100%]
[...]
=========================== short test summary info ============================
FAILED src/tests/functional/test_submissions.py::TestSubmissions::test_v15_iris_result_submission_end_to_end
FAILED src/tests/functional/test_submissions.py::TestSubmissions::test_v18_submission_end_to_end
FAILED src/tests/functional/test_submissions.py::TestSubmissions::test_v2_submission_end_to_end
ERROR src/tests/functional/test_submissions.py::TestSubmissions::test_v2_submission_end_to_end
========= 3 failed, 6 passed, 9 warnings, 1 error in 511.02s (0:08:31) ========= Which is weird because it works on my local machine. I was able to create a new competition after installing Codabench from scratch from the caddy branch. |
When you run the tests locally do you get any error? |
This is after running the tests locally (I copied the same commands that CircleCI launches): src/tests/functional/test_competitions.py .... [ 44%]
src/tests/functional/test_login.py . [ 55%]
src/tests/functional/test_submissions.py .... [100%] ========================== 9 passed, 9 warnings in 189.03s (0:03:09) ============================ This is the result with the |
For some reason, the tests now successfully passes in CircleCI after the latest commit, which only fixed some spaces in the |
@ObadaS I am testing this PR and I'm facing issues. When I try to access http://localhost/, I get redirected to https://localhost/, and the platform is not loading. In the logs, I have this error: codabench-caddy-1 | {"level":"info","ts":1715929871.8110924,"msg":"using provided configuration","config_file":"/etc/caddy/Caddyfile","config_adapter":"caddyfile"}
codabench-caddy-1 | Error: adapting config using caddyfile: parsing caddyfile tokens for 'tls': wrong argument count or unexpected line ending after 'tls', at /etc/caddy/Caddyfile:3
codabench-caddy-1 exited with code 1 Is there any procedure I missed that is necessary for the update? |
@Didayolo Looking at the error message, it seems like you might not have entered a valid email address in the .env file, you need to uncomment the
I meant mostly to test different functionalities, like submitting a competition, loading a competition, creating a new user etc... |
|
@Didayolo Commenting |
@ObadaS OK, but then if we add a Couldn't we make this more robust and convenient? Note that we also have a |
We already have a Since |
@ mention of reviewers
@Didayolo @ihsaan-ullah
A brief description of the purpose of the changes contained in this PR.
This should fix the problem of persistent certificates on caddy:
./caddy_data:/data
which is used by the image to store important information, certificates included../caddy_config:/config
which is used by the image to store some configuration (I'm not sure if it's really needed in our case)./Caddyfile:/etc/Caddyfile
to./Caddyfile:/etc/caddy/Caddyfile
(new official location for the Caddyfile)./certs/caddy:/etc/caddycerts
which is not present on the official Docker HubIssues this PR resolves
#1349
A checklist for hand testing
Checklist