Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files tab, conditional rendering #1449

Merged
merged 1 commit into from
May 21, 2024
Merged

Files tab, conditional rendering #1449

merged 1 commit into from
May 21, 2024

Conversation

bbearce
Copy link
Collaborator

@bbearce bbearce commented May 21, 2024

@ mention of reviewers

@ihsaan-ullah @Didayolo

A brief description of the purpose of the changes contained in this PR.

If no files to list, Files tab is unselectable and not shown.

Issues this PR resolves

A checklist for hand testing

  • Find a competiton
  • Make sure there are no files participants should be able to see
  • Make sure you are in a phase
  • Look and make sure Files is not shown

image

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo linked an issue May 21, 2024 that may be closed by this pull request
@Didayolo Didayolo self-assigned this May 21, 2024
@Didayolo Didayolo merged commit aa6c2ae into develop May 21, 2024
1 check passed
@Didayolo Didayolo deleted the issue_1439 branch May 21, 2024 08:57
@Didayolo
Copy link
Collaborator

Thanks Benjamin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files tab is always there
2 participants