Related to issue #1451: Send snapshot created_at instead of at_date to front for display consistency #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_date to front for display consistency
2 tasks
Didayolo
changed the base branch from
develop
to
bugfix/storage/monitoring-tool/dates-consistency
Didayolo
merged commit 5a5a41b
into
codalab:bugfix/storage/monitoring-tool/dates-consistency
|
I merge this to a branch on |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
This piece of code fixes the inconsistency of the date send as the 'last snapshot date'. Before, the usage history tab in the analytics page was getting the correct date (created_at date) from the backend, and other tabs were getting the incorrect date (at_date date) from the backend. Now they all get the correct date.
Issues this PR resolves
Should solve Problem 2 of #1451
Checklist