WIP Downloading submissions v1 #1548
Merged
+283
−146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR
@ mention of reviewers
@Didayolo
Issue resolved
Description
The aim of this PR is to add the feature of downloading all or several submissions at once.
This bulk downloading is only accessible for a challenge administrator and is accessible through the submissions manager.
The user interface view could be improved by placing the drop down menu and apply button on the far right.
This implementation can(/should?) be improved by moving the zip_generator task computation from the django thread to a site-worker by un-commenting
# in_memory_zip = stream_batch_download.apply_async((pks,)).get()
and commentingin_memory_zip = stream_batch_download(pks)
in the filesubmissions.py
line 327.However, generating zip in a stream by a site-worker is not functional because Celery back end is not configured to return something. This is a part where I would need help if this implementation is mandatory.
Also, is there a good way to benchmark the cost of this feature on the Django thread? It should not block the responsiveness of Codabench.
The global implementation follows this path :
A checklist for hand testing
Checklist