Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixedPricePassThruGate: Excess funds sent via passThruGate will be permanently locked #105

Closed
code423n4 opened this issue May 8, 2022 · 2 comments
Closed

FixedPricePassThruGate: Excess funds sent via passThruGate will be permanently locked #105

code423n4 opened this issue May 8, 2022 · 2 comments
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/FixedPricePassThruGate.sol#L48
https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/FixedPricePassThruGate.sol#L53

Vulnerability details

Details & Impact

If msg.value exceeds gate.ethCost, the difference remains permanently stuck in the price gate because the call to the beneficiary is only gate.ethCost.

Recommended Mitigation Steps

Just like the speedBumpGate, the call to the beneficiary should be msg.value instead of gate.ethCost.

(bool sent, bytes memory data) = gate.beneficiary.call{value: msg.value}("");
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels May 8, 2022
code423n4 added a commit that referenced this issue May 8, 2022
@code423n4
hickuphh3 issue #105
73b3d67
@illuzen
Copy link
Collaborator

illuzen commented May 10, 2022 •
edited
Loading

duplicate #64

@illuzen illuzen closed this as completed May 10, 2022
@illuzen illuzen added the duplicate This issue or pull request already exists label May 11, 2022
@gititGoro
Copy link
Collaborator

Duplicate of #48

@gititGoro gititGoro marked this as a duplicate of #48 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@illuzen @gititGoro @code423n4