Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darian models #1

Merged
merged 8 commits into from
Aug 25, 2020
Merged

Darian models #1

merged 8 commits into from
Aug 25, 2020

Conversation

DarianRushworth
Copy link
Collaborator

Setup the Models and Seeders.
Defined relations:

  • User to many Completed Exercises
  • Exercises to many Completed Exercises
  • User many to many Exercises through Completed Exercises

@DarianRushworth DarianRushworth changed the base branch from master to development August 24, 2020 12:54
DiegoOTdC
DiegoOTdC requested changes Aug 24, 2020
View reviewed changes
Copy link
Collaborator

@DiegoOTdC DiegoOTdC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to hide the postgres url from development..

DiegoOTdC
DiegoOTdC reviewed Aug 24, 2020
View reviewed changes
Copy link
Collaborator

@DiegoOTdC DiegoOTdC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't ranking be an integer? instead of string?

@DiegoOTdC DiegoOTdC self-requested a review August 24, 2020 13:13
@DarianRushworth
Copy link
Collaborator Author

Database Url Hidden. Great find.

@StephBerg86 StephBerg86 merged commit 10ff1ca into development Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoOTdC DiegoOTdC DiegoOTdC approved these changes

@StephBerg86 StephBerg86 Awaiting requested review from StephBerg86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarianRushworth @DiegoOTdC @StephBerg86