Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diego code mirror component #1

Merged
merged 11 commits into from
Aug 25, 2020
Merged

Conversation

DiegoOTdC
Copy link
Collaborator

@DiegoOTdC DiegoOTdC commented Aug 24, 2020

What we need
A text/input field that resembles javascript. We ask the user a question about a certain method and the user will write his/her answer in this text field. Presses submit and then receives a message to see if it is correct or not.

The steps
I first installed codemirror and react-codemirror2 to be able to create this text field that "mirrors" javascript code.

I added a function that will compare the correct answer with the answer the user gave in all different kinds of ways.
edit: only need to compare strings

Then created the store/exercise with actions/reducer/selector to be able to get and select the correct answer.
I first hardcoded this, and later on replace it with the correct request.

After that I added a button to the component and a function that will check if the answer is correct and will then display a message correctly.

Then I removed the component from the homepage, since it was just for testing.

@DarianRushworth
Copy link
Collaborator

The equal component was a bit over my head, will try to understand it this evening. The rest looks really great, good work!

Copy link
Collaborator

@DarianRushworth DarianRushworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems perfect, I am happy with the request to the backend, route is correct and dealing of the response in reducer is top noch.

@DiegoOTdC DiegoOTdC merged commit 0a92b5a into development Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants