generated from Codaisseur/react-redux-jwt-bootstrap-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diego code mirror component #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equal component was a bit over my head, will try to understand it this evening. The rest looks really great, good work! |
DarianRushworth
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems perfect, I am happy with the request to the backend, route is correct and dealing of the response in reducer is top noch.
StephBerg86
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we need
A text/input field that resembles javascript. We ask the user a question about a certain method and the user will write his/her answer in this text field. Presses submit and then receives a message to see if it is correct or not.
The steps
I first installed codemirror and react-codemirror2 to be able to create this text field that "mirrors" javascript code.
I added a function that will compare the correct answer with the answer the user gave in all different kinds of ways.
edit: only need to compare strings
Then created the store/exercise with actions/reducer/selector to be able to get and select the correct answer.
I first hardcoded this, and later on replace it with the correct request.
After that I added a button to the component and a function that will check if the answer is correct and will then display a message correctly.
Then I removed the component from the homepage, since it was just for testing.