let find_coverage_files return files in a list instead of a set

codecov · Jun 6, 2023 · aad9ccf · aad9ccf
1 parent c13828c
commit aad9ccf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/codecov_cli/services/upload/coverage_file_finder.py b/codecov_cli/services/upload/coverage_file_finder.py
@@ -204,7 +204,7 @@ def find_coverage_files(self) -> typing.List[UploadCollectionResultFile]:
             if user_coverage_files_paths
         ]
 
-        return set(result_files + user_result_files)
+        return list(set(result_files + user_result_files))
 
     def get_user_specified_coverage_files(self, regex_patterns_to_exclude):
         user_filenames_to_include = []

diff --git a/tests/services/upload/test_coverage_file_finder.py b/tests/services/upload/test_coverage_file_finder.py
@@ -10,7 +10,7 @@ def test_find_coverage_files_mocked_search_files(self, mocker):
             "codecov_cli.services.upload.coverage_file_finder.search_files",
             return_value=[],
         )
-        assert CoverageFileFinder().find_coverage_files() == set()
+        assert CoverageFileFinder().find_coverage_files() == []
 
         coverage_files_paths = [
             Path("a/b.txt"),
@@ -22,10 +22,10 @@ def test_find_coverage_files_mocked_search_files(self, mocker):
             return_value=coverage_files_paths,
         )
 
-        expected = {
+        expected = [
             UploadCollectionResultFile(Path("a/b.txt")),
             UploadCollectionResultFile(Path("c.txt")),
-        }
+        ]
 
         assert CoverageFileFinder().find_coverage_files() == expected