Improve logging #143
Merged
Improve logging #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to strike the right balance between verbose and non-verbose mode in the CLI. Particularly for the upload command it's been not satisfactory. The list of files being uploaded as coverage is now listed in non-verbose mode. Plus there's a positive feedback now that the process (command) finished - for ALL commands. So you know that at least the CLI did its thing, even though there might still be errors. And again for the upload command, separate better the response from codecov-api and the response from the PUT request afterwards. To help debugging and all that.
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 94.70% 94.71% +0.01%
==========================================
Files 65 65
Lines 2039 2045 +6
==========================================
+ Hits 1931 1937 +6
Misses 108 108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dana-yaish
reviewed
May 9, 2023
| assert out_bytes == [ | ||
| ( | ||
| "info", | ||
| "Process Commit creating complete. --- {\"result\": \"RequestResult(error=RequestError(code='HTTP Error 403', params={}, description='Permission denied'), warnings=[], status_code=403, text='Permission denied')\"}", |
There was a problem hiding this comment.
can we get rid of the extra "" in the loggings?
There was a problem hiding this comment.
I don't think we can. But I agree that it was a bit too much in that message, so I decided to make it simpler (and not have the "" in the process)
It was a lot of data in the "process complete" message. We don't need all that just to let users know the process terminated. So breaking that up again into 2 messages, the 2nd having all the data in verbose level.
dana-yaish
previously approved these changes
May 10, 2023
dana-yaish
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to strike the right balance between verbose and non-verbose mode in the CLI.
Particularly for the upload command it's been not satisfactory. The list of files being uploaded as coverage is now listed in non-verbose mode.
Plus there's a positive feedback now that the process (command) finished - for ALL commands. So you know that at least the CLI did its thing, even though there might still be errors.
And again for the upload command, separate better the response from codecov-api and the response from the PUT request afterwards.
To help debugging and all that.