feat: make noop plugin recognizable #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context: codecov/feedback#258 Currently there's no way to disable plugins. We don't want to change the default to preserve compatibility with the uploader little magic tricks that were executed by default (as far as I know). These changes allow you to pass the `--plugin noop` option to the `create-upload` command in order to not execute any plugin.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 96.01% 96.02%
=======================================
Files 81 81
Lines 2814 2816 +2
=======================================
+ Hits 2702 2704 +2
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joseph-sentry
previously approved these changes
Feb 2, 2024
tests/plugins/test_instantiation.py
Outdated
| @@ -115,6 +115,11 @@ def test_get_plugin_xcode(): | |||
| assert isinstance(res, XcodePlugin) | |||
|
|
|||
|
|
|||
| def test_get_plugin_xcode(): | |||
There was a problem hiding this comment.
rename to test_get_plugin_noop
giovanni-guidini
requested review from
joseph-sentry,
adrian-codecov and
matt-codecov
matt-codecov
approved these changes
Feb 6, 2024
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: codecov/feedback#258
Currently there's no way to disable plugins.
We don't want to change the default to preserve compatibility with the uploader little magic tricks that were executed by default (as far as I know).
These changes allow you to pass the
--plugin noopoption to thecreate-uploadcommand in order to not execute any plugin.