Change findAllBySubmissionId method on UserFileRepository to findAllBySubmission #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() method [#185447786]
- Don't create the zipped file in the file system - The folder with the downloaded files from S3 is still created on the file system -- will need to change that next [#185447786]
- Directly transfer bytes from files to FileInputStream with a buffer, use only memory [#185447786]
[#185447786] Co-authored-by: Chibuisi Enyia <cenyia@codeforamerica.org>
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
[#185447786] Co-authored-by: Chibuisi Enyia <cenyia@codeforamerica.org>
[#185447786]
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org> Co-authored-by: Cypress Borg <cborg@codeforamerica.org> Co-authored-by: Bethany Seeger <bseeger@codeforamerica.org>
#185447786 Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org> Co-authored-by: Cypress Borg <cborg@codeforamerica.org> Co-authored-by: Bethany Seeger <bseeger@codeforamerica.org>
#185447786
#185447786 Co-authored-by: Ben Calegari <bcalegari@codeforamerica.org> Co-authored-by: Alex Gonzalez <agonzalez@codeforamerica.org>
- Tests failing in CI due to chrome driver issue [#185447786] Co-authored-by: Chibuisi Enyia <cenyia@codeforamerica.org>
[#185447786] Co-authored-by: Bethany Seeger <bseeger@codeforamerica.org>
Co-authored-by: Bethany Seeger <bseeger@codeforamerica.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We renamed the field on UserFile from submissionId to submission because JPA uses the whole Submission object when looking for UserFiles associated with a Submission, not just the ID. When we renamed the fields, JPA needed the associated method signatures to be changed to match in order for them to work correctly.