Make required fields in dates and address fragments configurable #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
reviewed
Jun 3, 2024
| @@ -3,6 +3,7 @@ | |||
| th:with=" | |||
| hasLabel=${!#strings.isEmpty(label)}, | |||
| hasAriaLabel=${!#strings.isEmpty(ariaLabel)}, | |||
| requireDateFields=${requireDateFields ?: false}, | |||
There was a problem hiding this comment.
Line 11 has a "required" variable - is that doing the same thing under a different name?
There was a problem hiding this comment.
Nope, just me totally not realizing I had already done the thing 😅
bseeger
reviewed
Jun 3, 2024
README.md
Outdated
| @@ -669,6 +669,41 @@ Here is an example of using it with the `screenWithOneInput` fragment: | |||
|
|
|||
| Note that passing `required=true` here will append the red `(required)` to the label. | |||
|
|
|||
| #### Special situation for requiring address fields | |||
|
|
|||
| Sometimes you may want to apply custom validations to address fields through actions that effectively | |||
There was a problem hiding this comment.
It might be good to add a pointer to the action for custom validations, so that they fully understand what this is referring to. Maybe capitalize "Actions" and have it be a link to "https://github.com/codeforamerica/form-flow?tab=readme-ov-file#actions"? Same for the date fields section below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.