Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: header and sidebar improvement #116

Merged
merged 5 commits into from
Dec 3, 2022
Merged

Conversation

pionxzh
Copy link
Contributor

@pionxzh pionxzh commented Dec 3, 2022

closes #75

Changes

  • Add Breadcrumb for repo page, dashboard page and profile page
  • Foldable sidebar
  • I have pushed Docs to the right side! (let me know if you don't like it)

Things we can discuss

  • the position of Expand > button is weird
  • Have a standalone HomePage
    • Automatically redirect logged-in user from / to /repos
    • Only /repos shows the "Dashboard" breadcrumb

Before

image

After

Expanded by default

image

Collapsed

image

Profile Page

Note:
In the original issue, the request is Codepod/{USERNAME}'s Profile
But I think it's duplicate information. So let's use CodePod / Profile 😄
image

Other pages who don't have a specific breadcrumb

image

Inrelevant Suggestions

  • Prettier IDE integration?
  • Windows developer might need some fix for file-watching
// ui/config-overrides.js
config.watchOptions = {
    ignored: /node_modules/,
    poll: true,
};

Copy link
Collaborator

@lihebi lihebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks Pionxzh!

@lihebi lihebi merged commit 2b93901 into codepod-io:main Dec 3, 2022
@lihebi
Copy link
Collaborator

lihebi commented Dec 3, 2022

Prettier IDE integration?

Do you mean the prettier VSCode plugin for auto-formatting? It seems to only work with VSCode out-of-the-box, but not Monaco editor. We may be able to integrate it with some effort though.

The Monaco editor does support Command Palette and a basic version of formatting & indenting. You can press <F1> inside the editor to call out the Command Palette. Make the code editor bigger to see all the commands. One more thing, python has no auto-format command by default; you have to change it to e.g., javascript t see the command. Screenshot:

Screenshot 2022-12-03 at 11 04 50 AM

@lihebi
Copy link
Collaborator

lihebi commented Dec 3, 2022

  • Windows developer might need some fix for file-watching
// ui/config-overrides.js
config.watchOptions = {
    ignored: /node_modules/,
    poll: true,
};

I don't have a Windows machine, but this looks reasonable to me. Can you submit a PR for it as well? Thanks!

@pionxzh
Copy link
Contributor Author

pionxzh commented Dec 4, 2022

Prettier IDE integration?

Do you mean the prettier VSCode plugin for auto-formatting? It seems to only work with VSCode out-of-the-box, but not Monaco editor. We may be able to integrate it with some effort though.

The Monaco editor does support Command Palette and a basic version of formatting & indenting. You can press <F1> inside the editor to call out the Command Palette. Make the code editor bigger to see all the commands. One more thing, python has no auto-format command by default; you have to change it to e.g., javascript t see the command. Screenshot:

Ah, yes. I using vscode. Actually I'm not sure should an open source project provide some IDE related configuration.
Instead, we can setup the precommit lint to make sure that you can only submit formatted code.

@pionxzh pionxzh deleted the header-drawer branch December 4, 2022 04:32
@pionxzh
Copy link
Contributor Author

pionxzh commented Dec 4, 2022

  • Windows developer might need some fix for file-watching
// ui/config-overrides.js
config.watchOptions = {
    ignored: /node_modules/,
    poll: true,
};

I don't have a Windows machine, but this looks reasonable to me. Can you submit a PR for it as well? Thanks!

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas-view polishing Nov. 22
2 participants