Fix: Lock interactivity & sync width resize & improve render performance #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yjs
servers from a guest. In this early stage, a user may feel a little inconvenient to select text in a pod without the button, however, they can fix the viewpoint by pressing Control temporarily. We (@lihebi ) will implement some other robust method to add auth layer to the yjs servers and fix the viewpoint automatically in the future if we have time.codeNode
is re-rendered: manage theisEditorBlur
state globally instead of locally, otherwise,MyMonaco
will be re-render over and over again any time thecodeNode
changes. If we click on the editor and then click other places, you can see it causes the re-rendering ofMyMonaco
twice, which takes much time:But after we apply this PR, any update propagation stops at the
MyMonaco
.It reduces the re-render overhead a lot, especially when you drag a codeNode.