Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rich-text node #160

Merged
merged 5 commits into from
Dec 21, 2022
Merged

feat: add rich-text node #160

merged 5 commits into from
Dec 21, 2022

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Dec 21, 2022

This PR adds a rich-text editor using Remirror, a descendant of prosemirror. You can create it via right-click menu.

TODOs:

  • save to DB and sync with yjs

Screenshot:

Screenshot 2022-12-21 at 9 58 38 AM

@lihebi lihebi linked an issue Dec 21, 2022 that may be closed by this pull request
@lihebi lihebi changed the title feat: add rich-text node (WIP) feat: add rich-text node Dec 21, 2022
@lihebi
Copy link
Collaborator Author

lihebi commented Dec 21, 2022

UPDATE: now the content is saved to DB. This rich-text editor is not synced with collaborators. The yjs integration will be handled in another PR.

@lihebi
Copy link
Collaborator Author

lihebi commented Dec 21, 2022

Know issue: the app will throw the following error during development. It seems to be caused by Remirror's use of :first-child, ref: remirror/remirror#1785

Screenshot 2022-12-21 at 3 12 26 PM

@lihebi lihebi changed the title (WIP) feat: add rich-text node feat: add rich-text node Dec 21, 2022
@lihebi lihebi merged commit fc02934 into main Dec 21, 2022
@lihebi lihebi deleted the add-richtext branch June 30, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Richtext and Markdown cells
1 participant