fix: drag on toolbar handle into a scope #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragging on the toolbar handle into the scope might not work.
This is because the new darg handler in the toolbar (#248) is outside of the node, and there was a check that will prevent moving into a scope. The check was used to restrict a node not to be moved outside its parent scope. This restriction was removed in #236 to support auto-shrink/enlarge, so we no longer need to check the positions. Removing that check fix the regression.
The scope should have a shadow when a node is dragging over it. The dragging shadow was not working due to a CSS class name change in #241, this PR fixes that as well.