fix: filter comment nodes when compile ForStmt #267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree-sitter normally parses a for-statement into
[left,right,body]
, but if there're comments at the beginning of the body, it will be parsed into[left,right,comment,comment,...,body]
. This causes our compiler to miss the real body. This PR fixes it.Before, no unbound identifiers are marked:
After, unbound identifiers are marked correctly: