Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylize output box options #336

Merged
merged 2 commits into from
Jun 21, 2023
Merged

stylize output box options #336

merged 2 commits into from
Jun 21, 2023

Conversation

forrestbao
Copy link
Collaborator

Adjust how output box options are displayed:

image

image

Ref: #321

@forrestbao forrestbao requested a review from lihebi June 20, 2023 05:06
@lihebi
Copy link
Collaborator

lihebi commented Jun 20, 2023

The buttons are overlapped with the output text. This will make it hard to select the text. Does that matter?

@forrestbao
Copy link
Collaborator Author

Good question I let the menu hover over the output text on purpose.

In case one wants to select the output, it's not that hard. Just start the selection from the top left corner.

Maybe I can even add a button "copy output"

image

@lihebi
Copy link
Collaborator

lihebi commented Jun 20, 2023

I see. Yes, I'm good with this design.

Copy link
Collaborator

@lihebi lihebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use prettier (with default option) to format your code.

display: "flex",
fontSize: "0.8em",
}}
>
<CheckCircleIcon
style={{ marginTop: "5px" }}
style={{ marginTop: "5px"}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

variant="text"
size="small"
>
}} >
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

sx={{
// border: '1px solid #757ce8',
fontSize: "0.8em",
backgroundColor: 'white',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting (double quotes)

@forrestbao
Copy link
Collaborator Author

forrestbao commented Jun 21, 2023

Pretty-formatted. Take a look when you can. @lihebi

@lihebi
Copy link
Collaborator

lihebi commented Jun 21, 2023

Cool, thanks!

@lihebi lihebi merged commit 27c4c12 into codepod-io:main Jun 21, 2023
li-xin-yi pushed a commit to li-xin-yi/codepod-1 that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants