Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pls fix grammar #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

pls fix grammar #26

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2020

thx

BothOfUsTogether2 added 3 commits March 26, 2020 06:33
added instruction for installing using anaconda3
Copy link
Contributor

@wenmin-wu wenmin-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BothOfUsTogether2 , thanks for your contribution.

README.md Outdated

* install it using anaconda3:
clone the repo `git clone https://github.com/wenmin-wu/jupyter-tabnine`
install it `git clone https://github.com/wenmin-wu/jupyter-tabnine`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it was a typo, can't install with git clone

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry!

instead of second line should be:

install it like: ~/anaconda3/bin/python3.7 setup.py install

I really like this project and want to contribute but I have no ML background .. (don't know where to start.)

Kindly check this issue https://github.com/wenmin-wu/jupyter-tabnine/issues/28 or tell me how to debug and hopefully fix it?

The only problem is auto complete of methods, see example below:
x = "3"
auto complete not work here -> x.

Copy link
Contributor

@wenmin-wu wenmin-wu Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change your codes and commit again? Let me have a look at your issue.

@ghost ghost requested a review from wenmin-wu March 27, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant