Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karma-webpack): don't include the file extension (output.filename) #346

Closed
wants to merge 1 commit into from

Conversation

Havunen
Copy link

@Havunen Havunen commented Sep 1, 2018

This PR contains a bug fix

#322

@jsf-clabot
Copy link

jsf-clabot commented Sep 1, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title Fixes issue where transpiled code is read from wrong path. Github #322 fix(karma-webpack): transpiled code is read from the wrong path Sep 1, 2018
@michael-ciniawsky michael-ciniawsky added this to the 4.0.0 milestone Sep 1, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(karma-webpack): transpiled code is read from the wrong path fix(karma-webpack): don't include the file extension (output.filename) Sep 1, 2018
@michael-ciniawsky
Copy link
Contributor

@Havunen Please sign the CLA

@edmorley
Copy link

edmorley commented Sep 2, 2018

The appveyor CI run failed due to the NPM DNS issue which should now be resolved. Could someone retrigger? :-)

@ryanclark
Copy link
Collaborator

ryanclark commented Sep 2, 2018

How does this work with entry files that have an extension that isn’t .js? .ts, .coffee etc.

@michael-ciniawsky
Copy link
Contributor

Yeah, its' very weird why [name].js doesn't work with karma-webpack. I was even under the impression the extension needs to present in config.output.filename... Maybe this is a bug somewhere else in the code

@ryanclark
Copy link
Collaborator

It turns out the issue was a bit different than the filename having .js in it - I've submitted a PR (#347) that fixes the issues with it. I'm closing this as it's no longer needed, thank you though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants