Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stress test staging #731

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

stress test staging #731

wants to merge 5 commits into from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Mar 24, 2023

This should run the tests against staging. I intend to let a couple of A/B tests run with high concurrency

@ntabris
Copy link
Member

ntabris commented Mar 25, 2023

This looks like it had fewer concurrent cluster than I often see in prod:

image

e.g., here's the last 2 days in prod:

image

Does CI still start a new run on each push of new commits to a branch?

@fjetter
Copy link
Member Author

fjetter commented Mar 27, 2023

Does CI still start a new run on each push of new commits to a branch?

It should, yes. On prod it is still possible to go higher than the per-job limits since GH allows 20 concurrent jobs in total.

Every ordinary CI job is using 4 processes / concurrent Coiled clusters. With multiple branches we can easily go higher than this.

A/B tests are what's most important since every A/B tests is running 5 concurrent CI jobs with 4 processes per job

Comment on lines 39 to 43
ci_jobs: 5
ci_jobs: 20
# Number of parallel test_*.py modules per A/B test job.
# Each module typically spawns one Coiled cluster at a time.
# Set to 1 to disable pytest-xdist.
pytest_workers_per_job: 4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the gh actions runner manage to spin up 8 processes (I noticed pytest-xdist not handle scenarios very well if there are more jobs requested than there are CPUs) but this should produce 160 concurrent clusters

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, plus the ordinary tests, so I expect something above 200 ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants