Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Coin{Max,Min} by std::{max,min} #201

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

a-andre
Copy link
Contributor

@a-andre a-andre commented Aug 13, 2024

No description provided.

@tkralphs
Copy link
Member

tkralphs commented Aug 16, 2024

The failures here have nothing to do with the PR, as far as I can see. The problem is that the build of Cbc is not even being started. There are some very strange errors, such as the apt-get command not being found and eventually, the coinbrew command also not being found, thus Cbc is not built. I spent a good amount of time digging around and I just cannot see what is going on here yet. The PR looks fine and I'm sure has nothing to do with this, but we should try to fix these errors before merging.

@tkralphs tkralphs merged commit b91b787 into coin-or:master Aug 19, 2024
10 checks passed
@tkralphs
Copy link
Member

Now that we have this PR merged and all the builds (including the new arm64 ones) seem to finally be working, I'm planning to push out a new release (after doing releases of the Cbc stack). Let me know if there's more that you plan to do that I should wait on.

@a-andre a-andre deleted the max_min branch August 19, 2024 16:50
@a-andre
Copy link
Contributor Author

a-andre commented Aug 19, 2024

Go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants