Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Improve test coverage in 5 places for production code #629

Closed
2 tasks
niccokunzmann opened this issue Jun 17, 2024 · 3 comments
Closed
2 tasks

Python: Improve test coverage in 5 places for production code #629

niccokunzmann opened this issue Jun 17, 2024 · 3 comments
Labels
good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/

Comments

@niccokunzmann
Copy link
Member

niccokunzmann commented Jun 17, 2024 •
edited
Loading

The production code is mostly covered by the tests. Sometimes, __repr__ or if conditions are not covered though. That would be nice!

To close the issue:

  • cover 5 additional spots in the tests
  • create a pull request with your changes and get it merged

What will help:

  • Follow the documented development setup
  • After running the tests, you will have a coverage report as an HTML file.
  • Create a Pull Request and we will see the improvements.
@niccokunzmann niccokunzmann added good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ labels Jun 17, 2024
@devdanzin
Copy link
Contributor

We are working on this. Would you like me to send a PR to add --branch to the coverage run options in tox.ini?

@niccokunzmann
Copy link
Member Author

Would you like me to send a PR to add --branch to the coverage run options in tox.ini?

You are welcome to create PRs with improvements or create issues to discuss those first.

@mtrd3v mtrd3v mentioned this issue Jul 25, 2024
Merged
@niccokunzmann
Copy link
Member Author

@mtr-d3v Thanks for solving this in #696!

@devdanzin devdanzin mentioned this issue Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niccokunzmann @devdanzin