Improved test coverage in 5 places for production code

[mtrd3v]

This PR fixes issue #629 by Improving test coverage in 5 places for production code

---

📚 Documentation preview 📚: https://icalendar--696.org.readthedocs.build/

[coveralls]

Pull Request Test Coverage Report for Build 10100505716

Details

• 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 97.603%

---

Totals
Change from base Build 10021630821:	0.2%
Covered Lines:	3176
Relevant Lines:	3254

---

💛 - Coveralls

[niccokunzmann]

Thanks! While looking through it: you found mistakes in the code by improving the coverage. 🥳 could you correct that too or create an issue for it? vCalAddress('b'value'') repr should be vCalAddress('value') and vBinary repr probably vBinary(b'value') My guess is that changing python 2 to 3 did this.

[mtrd3v]

Thanks for reviewing my PR. I have corrected them.

[niccokunzmann]

Could you merge master?

[niccokunzmann]

Thanks, I made the changes clearer that I would like to see. Do you think this can be implemented in this pull request?

It is strictly not what the issue said, so I could merge it and create a first-timer issue instead.

What do you prefer?

[niccokunzmann]

Suggested change

	assert repr(instance) == "vBinary('b'value'')"
	assert repr(instance) == "vBinary(b'value')"

[mtrd3v]

I have fixed the issue. Now you can check.

[niccokunzmann]

@mtr-d3v Thanks! I just merged master so there is no conflict. It seems that the tests are updated and fail.

Could you install tox and run the tests in your local setup?

I am wondering why not all the tests were running before ...

[mtrd3v]

I have fixed the repr for vBinary and vCalAddress, the tests should pass now.

[niccokunzmann]

Thank you very much!