Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Require pytz #294

Closed
wants to merge 3 commits into from

Conversation

speedplane
Copy link

@speedplane speedplane commented Sep 11, 2019

In this pull request, we don't explicitly require pytz unless the ical events use timezones. pytz is a huge library, and many often try to avoid it if they do not need it. In this case, if you're just using the library to generate all-day events, it isn't strictly necessary.

@mister-roboto
Copy link

@speedplane thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@speedplane
Copy link
Author

@jenkins-plone-org please run jobs

@niccokunzmann
Copy link
Member

@speedplane, we are in the process of setting up maintenance for this repository again, see #360. It will take some time but I hope, we will get further towards integrating your changes. Thanks a lot for the effort and patience already!
If you like to run the latest tests for this PR, you can rebase/merge master.

@niccokunzmann
Copy link
Member

niccokunzmann commented Aug 21, 2022

from icalendar.parser import tzid_from_dt

Other modules might need modification now, after that long time.
Also, adding a test would be good: run a new file that imports icalendar, parses a file and checks that pytz is absent.

I quite like this PR as it allows that we support pytz and tzinfo in the future without requiring the import of pytz.

@niccokunzmann
Copy link
Member

I will close this for now as it did not receive any attention towards changes. It inspired other issues! It can be opened again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants