-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoneinfo #623
Zoneinfo #623
Changes from 71 commits
ec3c8dc
78d21ca
678feb9
83e1ec6
768741f
077e7af
8b4d871
8390c49
f446169
71acafe
caf2c7f
5ed7fca
c7629e1
8415bb0
3404241
9af4a8d
6ee184c
1452fcf
40dd7bb
7a1aeee
19d4a9d
01e9529
e4debef
50c583c
864a144
e45ce94
1c795ed
300e6d1
22db734
c0a13c3
6288697
942490e
e1b1127
0e11a23
b75be65
9035a22
2457f36
c9f425b
9e89a02
21211cc
b920876
a7d8185
9bea7f7
864987c
9bea8a0
4eb94f5
83eb74b
ee31374
86af756
307a28b
a4c9ecd
c9f6c90
e5785ec
0d158c6
5146c08
5762ac3
0cef73b
9a86aa2
3e021a6
5fd11f3
b3fc6f8
abe94fb
6478c12
a799e4c
4583615
96b4e76
fa4db23
5c4c11e
2ee6137
50f9765
99084fb
d0fd617
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,9 +210,8 @@ Python type:: | |
>>> vDatetime.from_ical('20050404T080000') | ||
datetime.datetime(2005, 4, 4, 8, 0) | ||
|
||
>>> dt = vDatetime.from_ical('20050404T080000Z') | ||
>>> repr(dt)[:62] | ||
'datetime.datetime(2005, 4, 4, 8, 0, tzinfo=<UTC>)' | ||
>>> vDatetime.from_ical('20050404T080000Z') | ||
datetime.datetime(2005, 4, 4, 8, 0, tzinfo=ZoneInfo(key='UTC')) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
No problem. The icalendar library isn't responsible to provide pytz to the consuming project. |
||
|
||
You can also choose to use the decoded() method, which will return a decoded | ||
value directly:: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,3 +46,6 @@ | |
q_split, | ||
q_join, | ||
) | ||
|
||
# Switching the timezone provider | ||
from icalendar.timezone import use_pytz, use_zoneinfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also mentioned for version 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at these:
We do not really make a release for 4.x, nobody invests time. For 5.x there will not really be a future release either because you can add one line to the code and then use 6.x. So, the claims will be dropped to support older versions but this is not part of this PR. The PR is for zoneinfo compatibility, also not for the next release. We can create an issue for the next release and what should be done, I think.