Streamline CIV creation and validation code for archive items and display sets

[amickan]

Closes #3138
Part of https://github.com/DIAGNijmegen/rse-roadmap/issues/274

With this change to use the same logic and code for CIV creation for display sets and archive items, it is no longer possible to update the interface of an image in an archive item. We already discussed this here briefly and had decided that this was no longer necessary.

[jmsmkn]

With this change to use the same logic and code for CIV creation for display sets and archive items, it is no longer possible to update the interface of an image in an archive item. We already discussed this here briefly and had decided that this was no longer necessary.

How would a user achieve this now?

[jmsmkn]

Good cleanup, probably most of my questions come from the existing implementation.

[amickan]

With this change to use the same logic and code for CIV creation for display sets and archive items, it is no longer possible to update the interface of an image in an archive item. We already discussed this here briefly and had decided that this was no longer necessary.

How would a user achieve this now?

With the changes here, they can no longer do this. Do we really need that functionality? It has always been a pretty incomplete feature (only for archive items, only for images and only possible through the API). It was originally meant to enable users to change existing archive items with generic medical images or generic overlays into something more specific. The specific interfaces have been around for a while now, I would assume it's less of an issue now? Also, there is always the alternative that we delete existing archive items and the user uploads from scratch. Or, maybe better, we enable deleting images from archive items / display sets (we already have this for all other interface kinds anyway), then there won't be a need to change the interface.

[jmsmkn]

Do we really need that functionality?

I think it's pretty common but not a blocker for this PR.

Or, maybe better, we enable deleting images from archive items / display sets (we already have this for all other interface kinds anyway), then there won't be a need to change the interface.

We should enable that in a separate PR. Workflow would have to be to add the image as a new value, then remove the old one value. The other way around they would loose permission to add the image back.