Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add check to prevent comments on draft PRs from ui_preview.yaml #33694

Closed
wants to merge 2 commits into from

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Oct 2, 2024

Doesn't really make sense to have comments be posted on draft PRs when as a draft they're constantly being worked on. This just prevents unnecessary noise on draft PRs. ui_preview will only run once it's taken off draft.

@maxime-desroches
Copy link
Contributor

We should always run the full CI regardless of the state of a PR.
It is actually a really powerful tool to have a good CI so we should never limit its coverage.
Also the comment with the screenshots gets updated, so only one comment is posted in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants