Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy from 0.950 to 0.960 #1670

Merged
merged 2 commits into from
May 26, 2022
Merged

Bump mypy from 0.950 to 0.960 #1670

merged 2 commits into from
May 26, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 26, 2022

Bumps mypy from 0.950 to 0.960.

Commits
  • 0a4a190 Update version to 0.960
  • 128661c Friendlier errors for PEP 612 (#12832)
  • a54c84d Bring back type annotation support of dunder methods in stub generator (#12828)
  • 290f013 FindModuleCache: optionally leverage BuildSourceSet (#12616)
  • aa7c21a Typeshed cherry-pick: Ignore mypy errors in Python 2 builtins and typing (#78...
  • 644d5f6 checkexpr: cache type of container literals when possible (#12707)
  • b673366 speedup typechecking of nested if expressions (#12700)
  • 6db3d96 Avoid crashing on invalid python executables (#12812)
  • cb2c07b Fix crash on type alias definition inside dataclass declaration (#12792)
  • 3cd1e2c Fix namedtuple crash in unannotated function (#12804)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mypy](https://github.com/python/mypy) from 0.950 to 0.960.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.950...v0.960)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1670 (904d5af) into main (84a297f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
+ Coverage   66.86%   66.88%   +0.01%     
==========================================
  Files          93       93              
  Lines       16622    16622              
  Branches     4414     4414              
==========================================
+ Hits        11114    11117       +3     
+ Misses       4366     4364       -2     
+ Partials     1142     1141       -1     
Impacted Files Coverage Δ
cwltool/cwltool/job.py 62.84% <0.00%> (+0.19%) ⬆️
cwltool/job.py 80.27% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a297f...904d5af. Read the comment docs.

@mr-c mr-c enabled auto-merge (rebase) May 26, 2022 15:32
@mr-c mr-c added the ready label May 26, 2022
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't review the snyk issue (no permission to access it), but I believe it's not related to this update (since it's updating mypy).

+1, but maybe worth checking if it's something with the pinned version of rdflib.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snyk simply says "Failed to complete the test" 😞

Their docs say, from what I understand, that this is due to an unexpected build error. In this case reading the requirements.txt. I tried it on my Linux 3.8 from scratch, and rdflib was installed successfully.

Latest rdflib releases are 3.7+, so I think this is the best fix to get mypy working while supporting Python 3.6+. So +1 👍

@mr-c mr-c merged commit 2be19f3 into main May 26, 2022
@mr-c mr-c deleted the dependabot/pip/mypy-0.960 branch May 26, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants