Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1712

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Update CONTRIBUTING.md #1712

merged 3 commits into from
Aug 17, 2022

Conversation

jjkoehorst
Copy link
Contributor

Added make info at the end of the documentation related to useful make commands when developing for cwltool. Please check if the description is correct as I am not too familiar with make yet.

@jjkoehorst jjkoehorst requested a review from mr-c August 17, 2022 06:17
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1712 (e9e8a9e) into main (ceb38d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1712   +/-   ##
=======================================
  Coverage   66.46%   66.46%           
=======================================
  Files          89       89           
  Lines       15908    15908           
  Branches     4216     4216           
=======================================
  Hits        10573    10573           
  Misses       4236     4236           
  Partials     1099     1099           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @jjkoehorst ! I was inspired by your work and I added many additions.

jjkoehorst and others added 2 commits August 17, 2022 09:16
Added make info at the end of the documentation related to useful commands when developing for cwltool
@mr-c mr-c marked this pull request as ready for review August 17, 2022 07:16
@mr-c mr-c enabled auto-merge (squash) August 17, 2022 07:16
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mr-c mr-c disabled auto-merge August 17, 2022 07:33
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mr-c mr-c enabled auto-merge (squash) August 17, 2022 07:35
@mr-c mr-c merged commit f3a35f3 into main Aug 17, 2022
@mr-c mr-c deleted the jjkoehorst-patch-2 branch August 17, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants