Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace .decode method with str(bytes, "utf-8") #1998

Merged
merged 5 commits into from
May 3, 2024
Merged

Replace .decode method with str(bytes, "utf-8") #1998

merged 5 commits into from
May 3, 2024

Commits on May 3, 2024

  1. Replace .decode method with str(bytes, "utf-8") 

    This is because some bytes-like objects (such as memoryview) don't
have a "decode()" method.  It appears that the preferred way to get a
decoded string is to simply call the constructor with the bytes-like
object and the desired encoding.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
    @tetron
    tetron committed May 3, 2024
    Configuration menu
    Copy the full SHA
    aea67f7 View commit details
    Browse the repository at this point in the history

  2. Add tests to make codecov happy. 

    Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
    @tetron
    tetron committed May 3, 2024
    Configuration menu
    Copy the full SHA
    05ab09a View commit details
    Browse the repository at this point in the history

  3. Put back 'nosec' comment 

    Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
    @tetron
    tetron committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7d9630e View commit details
    Browse the repository at this point in the history

  4. Run format 

    Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
    @tetron
    tetron committed May 3, 2024
    Configuration menu
    Copy the full SHA
    07150f9 View commit details
    Browse the repository at this point in the history

  5. Test additional code paths in bytes2str 

    Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
    @tetron
    tetron committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7702c4f View commit details
    Browse the repository at this point in the history