"normalizeLabelContent" should not convert all content to lower case #204
Labels
Comments
|
Yeah I think that makes sense, I’ll have a look next week. |
robinst
added a commit
that referenced
this issue
May 13, 2021
…ookup This is useful for implementing a custom context that wants access to the original label instead of lowercased and whitespace-collapsed. Fixes #204.
|
Raised a PR for this change, have a look: #205 |
|
@robinst Thanks for your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I am building a protobuf language plugin for IntelliJ platform.
And I use the
commonmark-javafor document comment rendering.I need to resolve the references in document like
[selector][google.api.DocumentationRule.selector].So I create a
DelegateInlineParserFactoryto interceptInlineParserContextinstance.But I found the parameter
labelof thegetLinkReferenceDefinitionmethod has been converted to lower case byString label = Escaping.normalizeLabelContent(ref);in line 326 ofInlineParserImpl.javaThe
google.api.documentationrule.selectoris not a valid symbol, so I can't resolve it to a reference link to language element.Describe the solution you'd like
Maybe the case ignoring should not handle in
InlineParserImpl, it should pass the original label value toInlineParserContext, letInlineParserContextdecide whether to ignore case.The text was updated successfully, but these errors were encountered: