Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source spans of blocks with lazy continuation lines #339

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

robinst
Copy link
Collaborator

@robinst robinst commented Sep 14, 2024

Fixes #337. Thanks to @sylvainheraud for most of the test cases!

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (6bebfe2) to head (7be4204).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #339   +/-   ##
=========================================
  Coverage     95.01%   95.01%           
  Complexity      254      254           
=========================================
  Files           136      136           
  Lines          4353     4353           
  Branches        618      618           
=========================================
  Hits           4136     4136           
  Misses          116      116           
  Partials        101      101           
Files with missing lines Coverage Δ
...n/java/org/commonmark/internal/DocumentParser.java 98.18% <100.00%> (ø)

@robinst robinst merged commit 3785185 into main Sep 14, 2024
12 checks passed
@robinst robinst deleted the issue-337-lazy-continuation-line-source-span branch September 14, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong SourceSpan with lazy continuation lines
1 participant