Allow opinion group comment explorer to show auto-translations #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could make use of e2e test capability we now have. Will prob merge my docs for setting up google translate first (incoming PR), and ensure e2e suite has access to an api key. |
patcon
added
🔩 p:client-participation
♿ accessibility
|
Added screenshots to show how it looks now. added #todo's |
patcon
changed the title
|
@patcon this is a really cool feature. Do you want to split the checkbox items into standalone issues? Do you need help testing this, or otherwise getting it ready to merge? |
|
I'm good to push it forward :) Some of these I just dropped or lost track of when if i wasn't sure if they were likely to be merged (ie. lacking feedback) |
|
Sorry for not providing feedback on this sooner @patcon. This is great! Thanks. |
raulsperoni
pushed a commit
to proyectourgente/polis
that referenced
this pull request
Sep 1, 2021
…mment-explorer Allow opinion group comment explorer to show auto-translations
raulsperoni
pushed a commit
to proyectourgente/polis
that referenced
this pull request
Oct 26, 2021
…mment-explorer Allow opinion group comment explorer to show auto-translations
raulsperoni
pushed a commit
to proyectourgente/polis
that referenced
this pull request
Oct 26, 2021
…mment-explorer Allow opinion group comment explorer to show auto-translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-ticketed from #232 (comment)
@urakagi's commits for upstreaming.
This should allow comments below viz to be translated when exploring opinion groups.
Needs local testing with translation enabled. Will post screenshots
Screenshots (Before)
Comment voting (allow translation)
Comment explorer (no translations)
To Do