Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pure wgsl in default shader and explainer #27

Merged
merged 2 commits into from
Sep 5, 2023
Merged

pure wgsl in default shader and explainer #27

merged 2 commits into from
Sep 5, 2023

Conversation

munrocket
Copy link
Contributor

No description provided.

davidar
davidar requested changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@davidar davidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, now that WGSL has sensible type names 👍

components/editor/explainer.tsx Outdated
<pre style={{ color: theme.palette.neutral.main }}>
keyDown(32u) // returns true when the spacebar is pressed
keyDown(u32) // returns true when the spacebar is pressed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be 32 (ASCII for space), though looks like the trailing u isn't necessary anymore anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yea. Fixed!

@davidar davidar merged commit 9fce753 into compute-toys:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidar davidar davidar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@munrocket @davidar