Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line flags for host profile. #471

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

TobiSchluter
Copy link

This seems to be missing. With this, I can cross-build out of the box akin to

conan_cmake_run(
    SETTINGS ${settings}
    ENV ${conan_env}
    PROFILE_BUILD default
    PROFILE_HOST android

    REQUIRES
    boost/1.78.0
    catch2/2.13.8
    eigen/3.4.0
    expected-lite/0.6.2
    fmt/9.1.0
    nlohmann_json/3.11.2
    openssl/1.1.1o
    valijson/0.6
    BASIC_SETUP
    CMAKE_TARGETS
    CONAN_COMMAND ${CONAN_CMD}

    OPTIONS
    boost:without_stacktrace=True
    BUILD missing

    GENERATORS cmake_find_package)

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TobiSchluter
Copy link
Author

I seem to have managed to mess up this patch when copying it between my trees, sorry about the two separate commits. Now it includes the whole change.

@TobiSchluter
Copy link
Author

TobiSchluter commented Sep 25, 2023

Any interest? Just ran into this again when updating.
I have another patch which adds support for -c flags, but I'd like to get this out of the way first.

@memsharded
Copy link
Member

Hi @TobiSchluter

Thanks for your contribution, and sorry for taking so long to check it. We have been focused on releasing 2.0, and also for the new cmake-conan integration based on the new CMake dependency providers, there have been a few things that have fallen through the cracks.

@@ -302,6 +302,10 @@ function(conan_cmake_settings result)
conan_check(VERSION 1.24.0 REQUIRED DETECT_QUIET)
set(_SETTINGS ${_SETTINGS} -pr:b=${ARG})
endforeach()
foreach(ARG ${ARGUMENTS_PROFILE_HOST})
conan_check(VERSION 1.24.0 REQUIRED DETECT_QUIET)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hardcoded check repeated for every profile seems wrong. It seems the previous one for PROFILE_BUILD was a bit legacy and dirty, it shouldn't be done that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants